Incorporate Viper #1827
Merged
Incorporate Viper #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
rexagod
force-pushed
the
1738
branch
2 times, most recently
from
0e3ef5b
to
fed11c5
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
I agree but I would still prefer to have the efforts split into different PRs since it will be easier to review.
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
ACK @dgrisonnet, I'll break this PR up. |
Closed
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
rexagod
force-pushed
the
1738
branch
4 times, most recently
from
c2d4dbb
to
1214730
Compare
rexagod
commented
Nov 6, 2022
rexagod
force-pushed
the
1738
branch
2 times, most recently
from
1cc84ba
to
ca60701
Compare
|
Ready for review. |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
mrueg
reviewed
Nov 14, 2022
rexagod
commented
Nov 16, 2022
k8s-ci-robot
added
size/XL
|
Tidying up the commits. |
rexagod
force-pushed
the
1738
branch
4 times, most recently
from
4e2797d
to
2b2b205
Compare
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
--config flag defines the path to the kube-state-metrics options config file.
Reload KSM on-the-fly when a change is detected in the configuration. Meta changes (will squash)
Add end-to-end testing to verify hot-reloading for event-based changes stemming from the config file. Also, * sent in a doc fix that was missed earlier: https://github.com/kubernetes/kube-state-metrics/pull/1890/files#diff-380eca5a922c0ddbf67f04daefc6823e7ef0e197434d3a826d39c7063cdfa6d6R15, * updated fsnotify and viper dependencies (v1.6.0 and v1.14.0 respectively). Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
k8s-ci-robot
removed
the
needs-rebase
|
Ready for review. |
|
/hold cancel Thanks for this contribution @rexagod ! |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Add
--configflag to support supplying options from a config file, and hot-reload on any changes to it.How does this change affect the cardinality of KSM: No change.
Which issue(s) this PR fixes: Fixes #1738