-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: public Builder compatibility with the BuilderInterface #1994
fix: public Builder compatibility with the BuilderInterface #1994
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
thanks for the review. Do you think, it can be back-ported after to previous release branch? I think the first release with this change is |
QQ: want to know more about the context. What are the impacts of not backporting into Some new features can't be used or the binary will be broken. |
Sure, For context, we are vendoring part of the "kube-state-metrics" code in the datadog-agent (more details about why we are doing it in this blog post). So we tried to vendor the last version that uses |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, clamoriniere, L3n41c, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This pull request add the changes introduced by #1864 into the "public" Builder (
pkg/builder/Builder
).To avoid having future similar issue, this PR also add a interface type check between the
pkg/build/type/BuilderInterface
Interface and thepkg/build/Builder
struct. It should allow to catch at compilation time any discrepancy.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
It doesn't affect cardinality of KSM because it doesn't change any metrics generation logic.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #