Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Index out of range in metrics_store.SanitizeHeaders #2166

Merged
merged 1 commit into from
Aug 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pkg/metrics_store/metrics_writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,13 @@ func (m MetricsWriter) WriteAll(w io.Writer) error {
func SanitizeHeaders(writers MetricsWriterList) MetricsWriterList {
var lastHeader string
for _, writer := range writers {
for i, header := range writer.stores[0].headers {
if header == lastHeader {
writer.stores[0].headers[i] = ""
} else {
lastHeader = header
if len(writer.stores) > 0 {
for i, header := range writer.stores[0].headers {
if header == lastHeader {
writer.stores[0].headers[i] = ""
} else {
lastHeader = header
}
}
}
}
Expand Down