Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new metric kube_pod_scheduler #2222

Merged
merged 2 commits into from
Nov 8, 2023
Merged

feat: Add new metric kube_pod_scheduler #2222

merged 2 commits into from
Nov 8, 2023

Conversation

adinhodovic
Copy link
Contributor

What this PR does / why we need it:

Adds a new pod metric kube_pod_scheduler_name that allows seeing which scheduler scheduled the pod. Allows aggregation by scheduler.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Increases.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2207

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @adinhodovic!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 19, 2023
@dashpole
Copy link
Contributor

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 19, 2023
@adinhodovic
feat: Add new metric kube_pod_scheduler_name
c5c6c9a 
Signed-off-by: adinhodovic <hodovicadin@gmail.com>
@adinhodovic adinhodovic force-pushed the add-scheduler-name-metric branch from 0d9a9df to c5c6c9a Compare October 19, 2023 17:41
dgrisonnet
dgrisonnet reviewed Nov 6, 2023
View reviewed changes
internal/store/pod.go Outdated
"",
wrapPodFunc(func(p *v1.Pod) *metric.Family {
m := metric.Metric{
LabelKeys: []string{"scheduler_name"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if having something like kube_pod_scheduler{name="foo"} could be better to remove the redundancy with the metric name its label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that makes sense. Updated.

@adinhodovic adinhodovic changed the title feat: Add new metric kube_pod_scheduler_name feat: Add new metric kube_pod_scheduler Nov 7, 2023
dgrisonnet
dgrisonnet approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adinhodovic, dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7b8ea90 into kubernetes:main Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schedulerName in kube_pod_* metrics group
4 participants
@adinhodovic @k8s-ci-robot @dashpole @dgrisonnet