-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kube_pod_container_status_last_terminated_timestamp metric #2291
feat: add kube_pod_container_status_last_terminated_timestamp metric #2291
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Welcome @tetianakravchenko! |
/triage accepted |
@tetianakravchenko Tests seem to be failing here. |
…ests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
…ated_timestamp in pod tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Hey @rexagod I've fixed tests, please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just a nit. :)
internal/store/pod.go
Outdated
func createPodContainerStatusLastTerminatedTimestampFamilyGenerator() generator.FamilyGenerator { | ||
return *generator.NewFamilyGeneratorWithStability( | ||
"kube_pod_container_status_last_terminated_timestamp", | ||
"Last terminated time for a pod container, when container was terminated with kube_pod_container_status_last_terminated_reason, in unix timestamp.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Last terminated time for a pod container, when container was terminated with kube_pod_container_status_last_terminated_reason, in unix timestamp.", | |
"Last terminated time for a pod container in unix timestamp.", |
Is when container was terminated with kube_pod_container_status_last_terminated_reason
necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…_timestamp' metric Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
This feature would be super helpful! Anything missing to get this in? :) |
Hey @rexagod could you please have another look on this PR? |
/lgtm Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, tetianakravchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds
kube_pod_container_status_last_terminated_timestamp
metric to report the time when container was last time terminated with thekube_pod_container_status_last_terminated_reason
. This metric is useful for cases like getting the crash situation - as described in this issue: #1805 (comment)How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds a new metric in cases when the
kube_pod_container_status_last_terminated_reason
is reportedWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #