Dockerfile: Remove VOLUME directive.
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `VOLUME` directive causes Docker to provision host storage to cover the implicitly requested volume mount. For security reasons this may be disallowed by Kubernetes clusters, causing kube-state-metrics containers to fail to be created.
k8s-ci-robot
added
size/XS
This also seems right to me. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, brancz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VOLUMEdirective causes Docker to provision host storage to coverthe implicitly requested volume mount. For security reasons this may be
disallowed by Kubernetes clusters, causing kube-state-metrics containers
to fail to be created.
Besides that, this directive does not do anything and to my knowledge
never did.
@andyxning
cc @ironcladlou