kubeadm nodeselector for kube-proxy

[pablodav]

What keywords did you search in kubeadm issues before filing this one?

windows
nodeselector

Is a FEATURE REQUEST

What happened?

kubeadm initializes kube-proxy without nodeselector

What you expected to happen?

kubeadm initialize kube-proxy with nodeselector: beta.kubernetes.io/os: linux

Anything else we need to know?

As discussed in: kubernetes-sigs/kubespray#3200 (comment)
After kubeadm creates a cluster, I had to add these lines to patch kube-proxy: https://github.com/kubernetes-incubator/kubespray/pull/3200/files#diff-ebe5b99856c7b8e810a6745a735aa611R23

This adds the nodeselector: beta.kubernetes.io/os: linux to kube-proxy.

why it is needed? for a multi-os cluster (linux masters and nodes + windows nodes) if it is not added, kube-proxy pods could try to be created in windows nodes.

[neolit123]

currently, in kubeadm, kube-proxy pods can be scheduled on any node, because there are cases where users want to run the addon on worker nodes too.

why it is needed? for a multi-os cluster (linux masters and nodes + windows nodes) if it is not added, kube-proxy pods could try to be created in windows nodes.

in the future, there is potential for exposing the addon manifests that kubeadm uses for better control of what node restrictions apply to the addons.

also, it becomes a question if kube-proxy works OK on windows.
if not you need to apply the nodeSelector patch with the os label.

[neolit123]

#1091

/close

[k8s-ci-robot]

@neolit123: Closing this issue.

In response to this:

#1091

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pablodav]

Thanks!