Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinder: add test for patching kubeletconfiguration; cleanup test jobs #2707

Merged
merged 2 commits into from
Jun 14, 2022
Merged

kinder: add test for patching kubeletconfiguration; cleanup test jobs #2707

merged 2 commits into from
Jun 14, 2022

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 13, 2022 •
edited
Loading 

Add a kubeletconfiguration+strategic.yaml patch
that contains "shutdownGracePeriod: 1s".

Verify if the patch is applied. This is done only for
CP nodes, but exercises init/join/upgrade and the
patching / writing the kubelet config for worker nodes
is in the same code path.

We can only test patches at the k/k "master" level
to avoid having too many test jobs.

Ideally we should not backport "patches" fixes
to the old branches, unless they are already present
at k/k master.

xref #1682

@neolit123
kinder: add tests for patching a kubeletconfiguration target
6e15e40 
Add a kubeletconfiguration+strategic.yaml patch
that contains "shutdownGracePeriod: 1s".

Verify if the patch is applied. This is done only for
CP nodes, but exercises init/join/upgrade and the
patching / writing the kubelet config for worker nodes
is in the same code path.
@neolit123
kinder: exclude testing for patches in the support skew
432c6f3 
We can only test patches at the k/k "master" level
to avoid having too many test jobs.

Ideally we should not backport "patches" fixes
to the old branches, unless they are already present
at k/k master.
@neolit123 neolit123 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/test kind/feature Categorizes issue or PR as related to a new feature. area/kinder Issues to track work in the kinder tool labels Jun 13, 2022
@neolit123 neolit123 added this to the v1.25 milestone Jun 13, 2022
@neolit123 neolit123 requested a review from pacoxu June 13, 2022 14:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
This was referenced Jun 13, 2022
Closed
Merged
@neolit123
Copy link
Member Author

test infra PR:
kubernetes/test-infra#26557

@neolit123 neolit123 requested a review from RA489 June 13, 2022 14:38
@neolit123 neolit123 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 13, 2022
@neolit123 neolit123 changed the title 1.25 add kubeletconfig patch test kinder: add test for patching kubeletconfiguration; cleanup test jobs Jun 13, 2022
@RA489
Copy link
Contributor

RA489 commented Jun 13, 2022

/lgtm
/hold for another eye @pacoxu

feel free to cancel hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
pacoxu
pacoxu approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e3b44af into kubernetes:main Jun 14, 2022
@neolit123
Copy link
Member Author

looks like CI is failing for the new kubelet patch test:

ERROR: /var/lib/kubelet/config.yaml is not patched
One or more verify checks failed! See output above...
Error: failed to exec command: failed to execute command on node kinder-patches-control-plane-1: exit status 1

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-patches-latest/1536760310143127552
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-patches-latest

i will look tomorrow.

@pacoxu
Copy link
Member

pacoxu commented Jun 15, 2022 •
edited
Loading

The log shows

[patches] Applied patch of type "application/strategic-merge-patch+json" to target "kubeletconfiguration"
[kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
[kubelet-start] Starting the kubelet

It is really weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@SataQiu SataQiu Awaiting requested review from SataQiu

@RA489 RA489 Awaiting requested review from RA489

Assignees

@pacoxu pacoxu

@RA489 RA489

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neolit123 @RA489 @k8s-ci-robot @pacoxu