Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginnings of a test framework #149

Merged
merged 39 commits into from
Nov 29, 2017
Merged

Beginnings of a test framework #149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
240dad6
Add help text and barebones integration test
totherme Nov 27, 2017
bedfd1e
Add dependencies
totherme Nov 27, 2017
c7957c3
Ignore goland's .idea directory
totherme Nov 22, 2017
9096006
Add help text and barebones integration test
totherme Nov 27, 2017
782bee8
Add dependencies
totherme Nov 27, 2017
9d271bf
Add apiserver launcher to test framework
totherme Nov 22, 2017
6776524
Add etcd launcher to test framework
Nov 22, 2017
fc5d405
Add Fixtures struct, which can start+stop everything
totherme Nov 22, 2017
1714b31
Add CI for local development
totherme Nov 22, 2017
8988075
Wire the test framework in to the demo tests
hoegaarden Nov 22, 2017
4e870ff
Use ioutils.tempDir() to create temporary directories
hoegaarden Nov 23, 2017
0dfe20e
Use http:// as etcd URL scheme
hoegaarden Nov 23, 2017
8a92d31
Make Stop() wait for the processes to exit
totherme Nov 24, 2017
e7bb1e8
Add fixtures tintegration tests
totherme Nov 24, 2017
a04f002
Rework fakes to allow additional arguments
totherme Nov 24, 2017
2fd15f8
Refactor Etcd
totherme Nov 24, 2017
940bec8
Refactor APIServer
totherme Nov 24, 2017
ddd0a56
Unify fixture processes
totherme Nov 24, 2017
d99f3dc
Extract TempDirManager
totherme Nov 24, 2017
e2f4cd5
Allow more time to bring up the fixtures
hoegaarden Nov 24, 2017
5d670c4
Refactor away anonymous functions in integration test
totherme Nov 27, 2017
d6f4cc6
Refactor Etcd and APIServer, esp. Start() and Stop()
totherme Nov 27, 2017
2e5a832
Remove {Etcd,APIServer}StartStopper interfaces
totherme Nov 27, 2017
11eab48
Implement first command talking to the APIServer
totherme Nov 27, 2017
eca5aac
Add dependencies
totherme Nov 27, 2017
e2a217b
Track the time it takes to start&stop the fixtures
totherme Nov 27, 2017
8523ad3
Start the fixture processes in parallel
totherme Nov 27, 2017
63de385
Add test option to run performance tests
hoegaarden Nov 28, 2017
7df93be
Use a temporary directory for the APIServer's certs
totherme Nov 28, 2017
f5b7280
Make Etcd's DataDirManager interface private
totherme Nov 28, 2017
ff9f027
Drop privilages before running tests in CI
totherme Nov 28, 2017
b7cfe0f
Update comments on Start/Stop of the processes
hoegaarden Nov 29, 2017
c4e57df
Create nicer names for temporary directories
hoegaarden Nov 29, 2017
d88f71c
Change `.gitignore` strategy
hoegaarden Nov 29, 2017
d89f4c1
Switch to repo-global vendoring
hoegaarden Nov 29, 2017
849d4f9
Switch to repo-global vendoring, move dependencies
hoegaarden Nov 29, 2017
ccb54d2
Make `pre-commit.sh` work with the test framework
hoegaarden Nov 29, 2017
4d4026f
Make the framework test bash3 compatible
hoegaarden Nov 29, 2017
a304d58
Install ginkgo
hoegaarden Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bin/pre-commit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ go vet -all ./...
rc=$((rc || $?))

echo "Running go test"
go test -v ./...
go list ./... | grep -vF pkg/framework/test | xargs go test -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be some sort of "default" value for KUBE_ASSERT_DIR and maybe we can download the binaries before running go test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think this also ties back to making our think work well with go test. As soon as we have that we can retire our test wrapper script pkg/framework/test/scripts/run-tests.sh and think about better ways of handling the test binaries/assets resp. their location. We in fact have all those things in our backlog.

rc=$((rc || $?))

echo "Running test framework tests"
./pkg/framework/test/scripts/download-binaries.sh \
&& ./pkg/framework/test/scripts/run-tests.sh
rc=$((rc || $?))

exit $rc
2 changes: 1 addition & 1 deletion pkg/framework/test/democli/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func Execute() {
}
}

func init() {
func init() {
cobra.OnInitialize(initConfig)

// Here you will define your flags and configuration settings.
Expand Down