Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the defer calls that catch panics #28365

Closed
roberthbailey opened this issue Jul 1, 2016 · 2 comments
Closed

Remove the defer calls that catch panics #28365

roberthbailey opened this issue Jul 1, 2016 · 2 comments
Assignees
@lavalamp
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@roberthbailey
Copy link
Contributor

They tend to hide bugs in production: software crashes make it really clear when there is a problem; catching panics papers over the issue and makes it more difficult for monitoring systems to catch failures.

/cc @lavalamp @krousey
@roberthbailey roberthbailey added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 1, 2016
@lavalamp
Copy link
Member

lavalamp commented Jul 1, 2016

SGTM, they're no longer useful since we run apiserver with kubelet and it'll restart.

@lavalamp lavalamp self-assigned this Jul 11, 2016
@lavalamp lavalamp mentioned this issue Jul 11, 2016
Merged
@wojtek-t
Copy link
Member

@kubernetes/sig-api-machinery

k8s-github-robot pushed a commit that referenced this issue Jul 13, 2016
Merge pull request #28800 from lavalamp/reallypanic
aebc35a 
Automatic merge from submit-queue

Stop eating panics

Fixes #28365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lavalamp lavalamp

Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lavalamp @roberthbailey @wojtek-t