Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Automated cherry pick of fixes for "large leases overload event etcd" issue (96836) #100452

Merged
merged 3 commits into from
Apr 8, 2021
Merged

[1.18] Automated cherry pick of fixes for "large leases overload event etcd" issue (96836) #100452

merged 3 commits into from
Apr 8, 2021

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Mar 22, 2021 •
edited
Loading

Cherry pick of #97009 #97480 #98257 on release-1.18.

#97009: apiserver add --lease-reuse-duration-seconds to config lease
#97480: apiserver add metric etcd_lease_object_counts
#98257: api-server add --lease-max-object-count

All those three PRs are a fix for an issue where creating a large number of events was causing event-etcd overload (#96836).

Fixed a bug where a high churn of events was causing master instability by reducing the maximum number of objects (events) attached to a single etcd lease.

@lingsamuel @mborsz
apiserver add --lease-reuse-duration-seconds to config lease reuse du…
d89e43d 
…ration

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel @mborsz
apiserver add metric etcd_lease_object_counts
5339f9c 
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel @mborsz
api-server add --lease-max-object-count
9f5dede 
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver labels Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 22, 2021
@mborsz mborsz changed the title Automated cherry pick of #97009: apiserver add --lease-reuse-duration-seconds to config lease #97480: apiserver add metric etcd_lease_object_counts #98257: api-server add --lease-max-object-count [1.18] Automated cherry pick of fixes for "large leases overload event etcd" issue (96836) Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2021
@mborsz
Copy link
Member Author

mborsz commented Mar 22, 2021

#100084 for 1.20 cherry pick
#100450 for 1.19 cherry pick

@mborsz
Copy link
Member Author

mborsz commented Mar 22, 2021

/assign @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve

@kubernetes/release-managers - for cherrypick approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 23, 2021
@mborsz
Copy link
Member Author

mborsz commented Mar 23, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 23, 2021
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8e67804 into kubernetes:release-1.18 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@mborsz @wojtek-t @k8s-ci-robot @fedebongio @feiskyer @lingsamuel