Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.20] .: bump govmomi to v0.30.6 #120736

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[go1.20] .: bump govmomi to v0.30.6 #120736

merged 2 commits into from
Sep 20, 2023
+269 −91

Conversation

MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Sep 18, 2023 •
edited by liggitt
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bumping govmomi to include an error check fix needed to work with go1.20. We made this fix in the CI, but were reliant on the text matching of error strings, which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738
Tracking issue: vmware/govmomi#3174

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We probably would want to cherry-pick this to release branches that running on go1.20.

Does this PR introduce a user-facing change?

Fixes an issue where the vsphere cloud provider will not trust a certificate if:
* The issuer of the certificate is unknown (x509.UnknownAuthorityError)
* The requested name does not match the set of authorized names (x509.HostnameError)
* The error surfaced after attempting a connection contains one of the substrings: "certificate is not trusted" or "certificate signed by unknown authority"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @liggitt
/sig architecture

@MadhavJivrajani
.: bump govmomi to v0.30.6
fc6b19a 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Sep 18, 2023
@dims
Copy link
Member

dims commented Sep 18, 2023

@MadhavJivrajani when is this in-tree cloud provider going/scheduled to be removed?

liggitt
liggitt reviewed Sep 18, 2023
View reviewed changes
vendor/github.com/vmware/govmomi/object/host_certificate_info.go
case x509.UnknownAuthorityError:
case x509.HostnameError:
default:
if !soap.IsCertificateUntrusted(err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be helpful to add a release note describing the scenario where this cloud provider would not have been able to connect, or the error that would have surfaced

@liggitt
Copy link
Member

liggitt commented Sep 18, 2023

looks like a new lint error:

ERROR: staging/src/k8s.io/legacy-cloud-providers/vsphere/credentialmanager.go:1: : # k8s.io/legacy-cloud-providers/vsphere [k8s.io/legacy-cloud-providers/vsphere.test]
ERROR: vsphere/vsphere_test.go:168:36: cannot use vpx.Setting (variable of type []"github.com/vmware/govmomi/vim25/types".BaseOptionValue) as *"github.com/vmware/govmomi/simulator".Registry value in argument to vapi.New (typecheck)
ERROR: //go:build !providerless

@MadhavJivrajani
vsphere: adapt to govmomi bump
5c28fd2 
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@MadhavJivrajani
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2023
@MadhavJivrajani
Copy link
Contributor Author

/retest

@MadhavJivrajani
Copy link
Contributor Author

when is this in-tree cloud provider going/scheduled to be removed?

@dims - v1.30 at the earliest. In tree CPI is scheduled for 1.30, the legacy cloud provider itself I don't have an estimate for. Will need to follow up with SIG Cloud Provider.

cc @xing-yang fyi ^

@liggitt
Copy link
Member

liggitt commented Sep 19, 2023

/lgtm
/approve

please open the picks (or replay the dependency update rather than an automated cherry-pick) to 1.25+

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2feac400d2750896fb0f9ae96e1552d300fc386

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@liggitt liggitt mentioned this pull request Sep 19, 2023
Closed
34 tasks
@liggitt
Copy link
Member

liggitt commented Sep 19, 2023

blocked on kubernetes/test-infra#30759 (like all PRs)

@pacoxu
Copy link
Member

pacoxu commented Sep 20, 2023

/retest
test infra failure is fixed.

@k8s-ci-robot k8s-ci-robot merged commit b28622c into kubernetes:master Sep 20, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 20, 2023
@MadhavJivrajani MadhavJivrajani changed the title .: bump govmomi to v0.30.6 [go1.20] .: bump govmomi to v0.30.6 Sep 20, 2023
This was referenced Sep 20, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@MadhavJivrajani @k8s-ci-robot @dims @liggitt @pacoxu