-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/gce: add match conditions to PersistentVolume labeling webhook #121703
cluster/gce: add match conditions to PersistentVolume labeling webhook #121703
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3ada00e
to
3a3be64
Compare
I like this improvement :D |
3a3be64
to
957f584
Compare
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
957f584
to
84da8e6
Compare
Good catch, I updated the match condition to only check for
We can update the manifests in https://github.com/kubernetes-sigs/cloud-pv-admission-labeler/tree/main/manifests to include the match conditions, but maybe just leave it as a comment since only 1.28 clusters have match conditions enabled by default. |
/lgtm |
LGTM label has been added. Git tree hash: f14f9e3f855055073e3ea6f529523255edd6bdd3
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
In #121628 we disabled PersitentVolumeLabel admission controller and added a webhook as a replacement. This webhook only operates against GCE PD, AWS EBS, Azure Disk and vSphere volume PVs. Add a match condition such that the webhook is only invoked for these PVs.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: