dra scheduler: fix incorrect tracking of claim candidates for reallocation #122415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation When dealing with unschedulable pods, the intent was to deallocate only claims which are allocated and use delayed allocation. That if check wasn't handled correctly, causing also claims with immediate allocation to be considered as candidates. Found during code reading, probably has never occurred in practice yet.
k8s-ci-robot
added
release-note
|
/assign @bart0sh |
bart0sh
reviewed
Dec 20, 2023
| @@ -754,7 +754,7 @@ func (pl *dynamicResources) Filter(ctx context.Context, cs *framework.CycleState | |||
| // would just get allocated again for a random node, | |||
| // which is unlikely to help the pod. | |||
| if claim.Spec.AllocationMode == resourcev1alpha2.AllocationModeWaitForFirstConsumer { | |||
| state.unavailableClaims.Insert(unavailableClaims...) | |||
| state.unavailableClaims.Insert(index) | |||
There was a problem hiding this comment.
Would it make sense to cover this with a unit or e2e tests?
There was a problem hiding this comment.
There is a test which exercises deallocation, just not in a way that mattered here.
As this is such a subtle difference, I am not sure how to write a test that covers this.
There was a problem hiding this comment.
One test also makes sense to me.
/approve
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8c36b56c9cfaf99123538e63053cdd0c8ce0a413
|
|
/assign @kerthcet For approval. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Related to #122270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When dealing with unschedulable pods, the intent was to deallocate only claims which are allocated and use delayed allocation. That if check wasn't handled correctly, causing also claims with immediate allocation to be considered as candidates.
Special notes for your reviewer:
Found during code reading, probably has never occurred in practice yet.
Does this PR introduce a user-facing change?