KEP-4210: kubelet: add reason field to image gc metric #123345
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
8 tasks
k8s-ci-robot
added
area/kubelet
sig/node
|
/retitle KEP-4210: kubelet: add reason field to image gc metric |
k8s-ci-robot
changed the title
kannon92
reviewed
Feb 16, 2024
| @@ -50,6 +50,14 @@ const instrumentationScope = "k8s.io/kubernetes/pkg/kubelet/images" | |||
| // indexed as imageId-RuntimeHandler | |||
| const imageIndexTupleFormat = "%s,%s" | |||
|
|
|||
| // ImageGarbageCollectedTotalReason* specify the reason why | |||
There was a problem hiding this comment.
nit: maybe its worth documenting each one.
There was a problem hiding this comment.
personally I feel like the name and value, plus their use in code, is self documenting, does anyone else agree with Kevin here?
kannon92
reviewed
Feb 16, 2024
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7da39d5674b8c2ed4af8393bdd6cfab60e381792
|
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
image-gc-metric-reason
branch
from
d79b91b
to
c8b4d8e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: acfa8f02b0c1bab926b7dd25527bf8bbcc65f90e
|
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
saschagrunert
approved these changes
Feb 19, 2024
mrunalp
approved these changes
Feb 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
add image gc reason to metric
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: