let kubectl label use PATCH instead of PUT #15651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e test build/test passed for commit 873c1d28e3b1082cf0b3aff38ba9dfbd950a0f67. |
j3ffml
added
the
lgtm
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit 873c1d28e3b1082cf0b3aff38ba9dfbd950a0f67. |
caesarxuchao
force-pushed
the
label-patch
branch
from
873c1d2
to
b5a3ab6
Compare
|
PR changed after LGTM, removing LGTM. |
k8s-github-robot
removed
the
lgtm
|
GCE e2e test build/test passed for commit b5a3ab6. |
caesarxuchao
added
the
lgtm
|
add back "lgtm" since it's a rebase |
|
@k8s-oncall @bgrant0607 it seems the merge bot is not working. Shall I go ahead merging this? |
|
@caesarxuchao It's up to the build cop. |
piosz
added a commit
that referenced
this pull request
Oct 16, 2015
let kubectl label use PATCH instead of PUT
RiRa12621
added a commit
to RiRa12621/kubernetes
that referenced
this pull request
Sep 13, 2022
…ODO. All dependencies according to kubernetes#15651 (comment) are merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #15597, this PR lets
kubectl labeluse PATCH instead of PUTFix #15333
We can revert the retry function introduced to test-cmd.sh in #15325 after this one and #15597 are merged.
@bgrant0607 @janetkuo @jlowdermilk