Add spec.Name() to the configmap GetVolumeName() #28534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
|
GCE e2e build/test failed for commit 4c17e9638ed2ab2c520d952a88864efbc3bfbd95. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
This is to base the name on the volume not just on the source configMap. If you have 2 volumes that both have the same configMap as a source, the volume is see as being in the attached state (it's state is looked up based on GetVolumeName()). See bug kubernetes#28502
asalkeld
force-pushed
the
configmap-multi-ref
branch
from
4c17e96 to
d7150bf
Compare
k8s-github-robot
added
size/S
|
GCE e2e build/test passed for commit d7150bf. |
|
cc @pmorie |
saad-ali
added
lgtm
|
LGTM Thanks @asalkeld |
|
We should cherry pick this for the v1.3.1 release |
saad-ali
added
cherrypick-candidate
release-note-none
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit d7150bf. |
|
Automatic merge from submit-queue |
|
@asalkeld Can you make sure to create a cherry pick for this to the 1.3 release branch. |
fabioy
added
the
cherry-pick-approved
|
@asalkeld Cherrypick approved. Please create a cherrypick PR. Thanks. |
|
@asalkeld Ping on this. |
|
@saad-ali SG. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to base the name on the volume not just on the
source configMap. If you have 2 volumes that both have the same
configMap as a source, the volume is see as being in the attached
state (it's state is looked up based on GetVolumeName()).
Fixes #28502