Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GlusterFS provisioning readme with endpoint/service details #31854

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Update GlusterFS provisioning readme with endpoint/service details #31854

merged 1 commit into from
Sep 16, 2016

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Sep 1, 2016 •
edited by jessfraz
Loading 

Update GlusterFS provisioning readme with endpoint/service details

This change is Reviewable

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

5 similar comments
@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@humblec
Copy link
Contributor Author

humblec commented Sep 1, 2016

@rootfs PTAL at this PR

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Sep 1, 2016
@humblec
Copy link
Contributor Author

humblec commented Sep 1, 2016

@zmerlynn this PR is an update in provisioning readme to provide more details to user wrt the glusterfs DP configuration. Please have a look at the same. Thanks!

rootfs
rootfs reviewed Sep 1, 2016
View reviewed changes
examples/experimental/persistent-volume-provisioning/README.md
glusterfs-cluster 10.240.106.152:1,10.240.79.157:1
```

We need also create a service for this endpoints, so that the endpoints will be persisted. We will add this service without a selector to tell Kubernetes we want to add its endpoints manually.You can see [glusterfs-service.json](examples/volumes/glusterfs/glusterfs-service.json)for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to glusterfs-server.json is not correct. You have to go to the top of examples directory first.

@rootfs
Copy link
Contributor

rootfs commented Sep 1, 2016

@kubernetes/sig-storage

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2016
@lpabon lpabon mentioned this pull request Sep 1, 2016
Closed
@humblec
Copy link
Contributor Author

humblec commented Sep 2, 2016

@rootfs any thoughts why most of the tests are not running on this PR?

@rootfs
Copy link
Contributor

rootfs commented Sep 2, 2016

@k8s-bot ok to test

@dims
Copy link
Member

dims commented Sep 6, 2016

ok to test

@jsafrane jsafrane added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Sep 16, 2016
@jsafrane
Copy link
Member 

/go/src/k8s.io/kubernetes/examples/experimental/persistent-volume-provisioning/README.md
----
preformat-balance:
not printing failed chunk: too many lines
unbalanced triple backtick delimiters

remove-whitespace:
not printing failed chunk: too many lines
contents were modified

blank-lines-surround-preformatted:
not printing failed chunk: too many lines
contents were modified

header-lines:
not printing failed chunk: too many lines
contents were modified

analytics:
not printing failed chunk: too many lines
contents were modified

FAIL: changes needed but not made due to --verify
/go/src/k8s.io/kubernetes/examples/ is out of date. Please run hack/update-munge-docs.sh
FAILED   hack/make-rules/../../hack/verify-munge-docs.sh    10s

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 16, 2016
@humblec
Update glusterfs provisioner readme with endpoint/service details.
a601e8a 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Sep 16, 2016 •
edited
Loading

@jsafrane @childsb , I have rebased and corrected the formatting errors. Can you please restore LGTM? Also, this has to be in 1.4 tree.

@k8s-github-robot k8s-github-robot added retest-not-required-docs-only and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 16, 2016

GCE e2e build/test passed for commit a601e8a.

@childsb childsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ce5e0da into kubernetes:master Sep 16, 2016
@humblec humblec mentioned this pull request Sep 19, 2016
Closed
@childsb
Copy link
Contributor

childsb commented Sep 19, 2016

Should be in the 1.4.x branch: #33009

@childsb childsb added this to the v1.4 milestone Sep 19, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2016
@jessfraz jessfraz mentioned this pull request Oct 13, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 14, 2016
Merge pull request #34766 from jessfraz/automated-cherry-pick-of-#31854-
644988e 
#32198-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #31854 #32198 origin release 1.4

Cherry pick of #31854 #32198 on release-1.4.

#31854: Update glusterfs provisioner readme with endpoint/service
#32198: fixup storage examples
@jessfraz
Copy link
Contributor

cherry-picked in #34766

This was referenced Oct 25, 2016
Closed
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#34766 from jessfraz/automated-cherry-pi…
782bc55 
…ck-of-#31854-kubernetes#32198-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#31854 kubernetes#32198 origin release 1.4

Cherry pick of kubernetes#31854 kubernetes#32198 on release-1.4.

kubernetes#31854: Update glusterfs provisioner readme with endpoint/service
kubernetes#32198: fixup storage examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@humblec @k8s-bot @rootfs @dims @jsafrane @k8s-github-robot @childsb @jessfraz @zmerlynn @googlebot