Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PetSet to StatefulSet #35663

Merged
merged 7 commits into from
Oct 28, 2016
Merged

Rename PetSet to StatefulSet #35663

merged 7 commits into from
Oct 28, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Oct 27, 2016 •
edited
Loading

What this PR does / why we need it: #35534

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer: cc @erictune @foxish @kubernetes/sig-apps @ymqytw

Release note:

This change is Reviewable

@janetkuo janetkuo self-assigned this Oct 27, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2016
@AlexMioMio
Copy link

StatefulSet is better than PetSet,easy to understand

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2016
@janetkuo janetkuo added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-label-needed labels Oct 27, 2016
@janetkuo janetkuo assigned erictune and unassigned janetkuo Oct 27, 2016
This was referenced Oct 27, 2016
Closed
Closed
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit f483112. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2016
@janetkuo janetkuo force-pushed the statefulset branch 2 times, most recently from 18a0579 to 60bae07 Compare October 27, 2016 21:01
@janetkuo janetkuo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2016
@janetkuo janetkuo mentioned this pull request Oct 27, 2016
Merged
@smarterclayton
Copy link
Contributor

Had one questions for @caesarxuchao regarding the removal of the client, but otherwise this looks ok (we don't have to fix all nits here and I don't want you to rebase this more than once).

@janetkuo janetkuo mentioned this pull request Oct 27, 2016
Closed
11 tasks
@caesarxuchao
Copy link
Member

We have client-go now, it's not useful to keep old version of released clientset in the main repository, so I'm fine with changing the release_1_4 folder. I'll remove those folder entirely in another PR.

@smarterclayton I didn't see your question on github?

@janetkuo
Copy link
Member Author

We didn't quite settle on what we called the members of a StatefulSet, I
tried out "member" in the proposal. Probably can discuss and change later.

Yes it's in the petset rename checklist #35534. Current plan is to just call them pods

@bprashanth
Copy link
Contributor

I guess we can chip away at the internal types the controller uses like pcb (petControlBlock) and petSyncer. @m1093782566 fyi, since you volunteered to help.

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Oct 27, 2016 •
edited
Loading

@k8s-bot ok to test

@chrislovecnm
Copy link
Contributor

Nice ...

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Oct 28, 2016 •
edited
Loading

@janetkuo does this close the rename issue or just finishes out a few bullets?

@janetkuo
Copy link
Member Author

@chrislovecnm just the first two items

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 60bae07. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@janetkuo
Copy link
Member Author

janetkuo commented Oct 28, 2016 •
edited
Loading

This script just got merged before the 2nd test... 😢 will rebase and update it

FAILED   hack/make-rules/../../hack/verify-test-owners.sh

@janetkuo janetkuo added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 28, 2016
@janetkuo
Copy link
Member Author

@k8s-bot gci gce e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit e0252f9. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@chrislovecnm
Copy link
Contributor

@k8s-bot gci gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit e0252f9. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e37b7cb into kubernetes:master Oct 28, 2016
@chrislovecnm
Copy link
Contributor

When will this go into a beta release? And now we have to what PRs.

k8s-github-robot pushed a commit that referenced this pull request Nov 3, 2016
Merge pull request #35731 from janetkuo/statefulset-v1beta1
e817594 
Automatic merge from submit-queue

Move Statefulset (previously PetSet) to v1beta1

**What this PR does / why we need it**: #28718

**Which issue this PR fixes** _(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes #

**Special notes for your reviewer**: depends on #35663 (PetSet rename)
cc @erictune @foxish @kubernetes/sig-apps 

**Release note**:

``` release-note
v1beta1/StatefulSet replaces v1alpha1/PetSet.
```
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@silasbw silasbw mentioned this pull request Jan 12, 2017
Closed
@Dbz Dbz mentioned this pull request Feb 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictune erictune erictune left review comments

Assignees

@smarterclayton smarterclayton

@erictune erictune

@bprashanth bprashanth

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
10 participants
@janetkuo @AlexMioMio @k8s-ci-robot @smarterclayton @caesarxuchao @erictune @bprashanth @chrislovecnm @k8s-github-robot @googlebot