-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable update staging client in master. #39504
Conversation
/approve |
/lgtm |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Removing this from the merge queue until #39099 is settled. |
@caesarxuchao This enables auto-updating. I think this should wait until we sort out how to handle client-go vendoring. I think it should be done as part of a sync to client-go. |
I think we need to split the copy script into a script that copies the API types from k8s.io/kubernetes and a script that generates the client directly into client-go. After that, we do NOT run the vendoring step in kubernetes. Instead, there should be a client-go sync script like we have for apimachinery. If a bot were to sync all repos against the same kubernetes, the vendor dir could be built during that step and it would always have a matching set and we have no cycles. |
The process you proposed will work if there are only api/ and apis/ under client-go/pkg/. Otherwise staging/client-go will not compile because these other packages under staging/client-go/pkg/ can be out of date. I will write an alternative approach in kubernetes/client-go#78, let's see if it's more intuitive. |
d4f498c
to
7789cf3
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: k82cn Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
@caesarxuchao / @deads2k , thanks for your comments :). how about juts delete those lines comments? |
@k82cn: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Using |
I'm not too excited about generating clients in the publishing robot, it makes client-go's publishing process different from other repos. I think this idea is easier to think about. (oh I see you commented that idea is good, I'll experiment it and push something tomorrow) |
I think mainly I need to update the publishing robot to checkout the latest apimachinary and vendor it before publishing to k8s.io/client-go. I'll code it up tmr. I'll clean up copy.sh as well, but maybe we are not on the same page about copy.sh, we'll see :) |
Enable update staging client in master.