Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NetworkInterfaces and Subnets to nil before updating Azure security groups #40405

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

codablock
Copy link
Contributor

What this PR does / why we need it: This is a workaround until we have an upstream fix in azure-sdk-for-go/go-autorest. Corresponding issues are #40332 and Azure/go-autorest#112

In k8s 1.5.2, an update to azure-sdk-for-go was cherry-picked, which broke creation/updating of LBs on Azure. As we should have it back to a working state ASAP, I'd like to do a workaround for now and later when the upstream fix comes in, remove the workaround again.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #40332

Release note:

Fix failing load balancers in Azure

CC @colemickens

@k8s-ci-robot
Copy link
Contributor

Hi @codablock. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@colemickens
Copy link
Contributor

Is this the only validation blip? I'm worried about the loadbalancer updates as well.

@codablock codablock force-pushed the azure_lb_readonly_fix branch from c55838f to bf28a9b Compare January 25, 2017 08:28
@codablock
Copy link
Contributor Author

I just rechecked and retested and LB's are updated as expected. Which checking, I figured out that the same workaround was needed for the deletion path as well and added it to the PR.

@colemickens
Copy link
Contributor

lgtm then.

@wojtek-t wojtek-t removed their assignment Jan 27, 2017
@freehan freehan assigned brendandburns and unassigned freehan Jan 27, 2017
@codablock
Copy link
Contributor Author

@brendandburns Can you check this PR and give a LGTM maybe?

@brendandburns
Copy link
Contributor

@k8s-bot ok to test

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: brendandburns

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2017
@brendandburns
Copy link
Contributor

@saad-ali fyi for the cherry-pick, we'd like to get this into 1.5.3...

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@brendandburns
Copy link
Contributor

@k8s-bot cri node e2e test this

@codablock
Copy link
Contributor Author

I'd assume CI failure is not related to this PR.
@k8s-bot node e2e test this

@codablock
Copy link
Contributor Author

@k8s-bot kubemark e2e test this
@k8s-bot gci gce e2e test this
@k8s-bot cvm gce e2e test this
@k8s-bot gce etcd3 e2e test this
@k8s-bot cvm gke e2e test this
@k8s-bot gci gke e2e test this

@codablock
Copy link
Contributor Author

@k8s-bot kops aws e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 90a3828 into kubernetes:master Jan 31, 2017
@saad-ali saad-ali modified the milestones: v1.5, 1.6 Feb 2, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Feb 2, 2017
k8s-github-robot pushed a commit that referenced this pull request Feb 2, 2017
…rigin-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #40405

Cherry pick of #40405 on release-1.5.

#40405: Set NetworkInterfaces and Subnets to nil before updating
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure: loadbalancers are broken in 1.5.2
10 participants