-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang versions to 1.7.5 #41771
Conversation
Hi @cblecker. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. building cross image now, will push and then trigger tests.
@@ -18,7 +18,7 @@ | |||
# [GOLANG_VERSION=1.7.4] [REGISTRY=gcr.io/google-containers] [TAG=test] make (build|push) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not essential, but maybe update this comment too for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
|
/approve |
@k8s-bot test this |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: cblecker, ixdy, mikedanese Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot cross build this |
These don't look related to this PR, but it seems the queue is currently blocked. |
@k8s-bot non-cri e2e test this |
@ixdy Question: Is this worth cherrypicking back to release-1.5, as 1.5 is using go1.7.4 as well? |
@saad-ali FYI :) |
Also, maybe a dumb question as I'm relatively new around these parts.. |
There will be regular fast-forwards of the release-1.6 branch from master. |
Got it! Thank you! |
Automatic merge from submit-queue (batch tested with PRs 41812, 41665, 40007, 41281, 41771) |
@cblecker run the |
Awesome, thank you! I've opened #42005 using that script. Note: During conflict resolution, I removed a couple of the changes that were in this PR as there are parts of 1.5 that are still on go 1.6, and that is a much bigger jump. The cross-build image though was 1.7.4, so that's the big one. |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Kubernetes did so in kubernetes/kubernetes#41771 We're also starting to see failures with pulling the 1.7.4 image
What this PR does / why we need it: While #41636 might not make it in until 1.7, this would bump current golang versions from 1.7.4 to 1.7.5 to integrate the fixes from that patch version. This would include, among other things, a fix to ensure cross-built binaries for darwin don't have certificate validation errors (golang/go#18688)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): noneSpecial notes for your reviewer:
Release note: