-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow minion floating IPs to be optional #42638
Conversation
Hi @jamiehannaford. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot test this |
Nothing jumps out as incorrect in this template. It addresses a second major mode of network connectivity in OpenStack deployments. |
@eparis @hogepodge Do I need to incorporate anything else or is this approved? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: eparis, jamiehannaford Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
Automatic merge from submit-queue (batch tested with PRs 41297, 42638, 42666, 43039, 42567) |
What this PR does / why we need it:
Makes the generation of floating IPs for worker nodes optional, based on an env var. To quote the original issue:
Which issue this PR fixes:
#40737
Special notes for your reviewer:
I used the conditions section of the Heat spec: https://docs.openstack.org/developer/heat/template_guide/hot_spec.html#conditions-section
Release note: