Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(golang.org/x/oauth2): a6bd8cefa1811bd24b86f8902872e4e8225f74c4 #45056

Merged
merged 5 commits into from
May 4, 2017
Merged

bump(golang.org/x/oauth2): a6bd8cefa1811bd24b86f8902872e4e8225f74c4 #45056

merged 5 commits into from
May 4, 2017

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Apr 27, 2017 •
edited
Loading

As I tackle #42654 kubectl's OpenID Connect plugin will start using golang.org/x/oauth2 for refreshing, instead of go-oidc's own hand rolled oauth2 implementation. In preparation, update golang.org/x/oauth2 to include golang/oauth2@7374b3f which fixes refreshing with Okta.

We also somehow removed the dependency on google.golang.org/appengine. Maybe golang/oauth2@8cf5815?

cc @kubernetes/sig-auth-pr-reviews

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Apr 27, 2017
@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericchiang, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2017
@ericchiang ericchiang mentioned this pull request Apr 28, 2017
Merged
@ericchiang
Copy link
Contributor Author

@k8s-bot unit test this

@k8s-bot verify test this

@calebamiles
Copy link
Contributor

adding lgtm manually as this PR is approved by @smarterclayton and would otherwise need top level OWNER to ack again.

@calebamiles calebamiles added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e1423ac into kubernetes:master May 4, 2017
@ericchiang ericchiang deleted the update-oauth2 branch May 4, 2017 02:52
@ericchiang ericchiang mentioned this pull request Jul 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ericchiang @k8s-reviewable @smarterclayton @k8s-github-robot @calebamiles @jbeda @k8s-ci-robot