-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable shared PID namespace by default for docker pods #45236
Conversation
Hi @verb. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot ok to test |
@yujuhong the plan in the original proposal was to change the default behavior but provide an "escape hatch". When it became clear that Docker 1.13.1 would not be qualified for 1.6, @dchen1107 asked to make it experimental opt-in. That CL (#41583) didn't merge in time for 1.6. Since it already had an LGTM I decided to just let it merge (I didn't realize at the time I was going to have to get additional LGTMs because of rebasing) and follow up with a CL to change the default behavior for 1.7. Anyway, I'm just implementing the initial proposal, but I'm happy to revisit the rollout plan. |
Update ftr: @yujuhong, @dchen1107 and I met offline and agreed to make this a default for 1.7, so this PR is just waiting for review. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, verb, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot kops aws e2e test this |
Automatic merge from submit-queue |
@verb why was it experimental earlier and what makes it non experimental now. is there more documentation on how to use it ? Do we need to enable in kubelet earlier ? |
@krmayankk lack of defined process. It is automatically enabled for supported docker versions, >= 1.13.1. Note that 1.13.1 has not been qualified for use with Kubernetes yet. See kubernetes/community#207 for additional details of the rollout. |
What this PR does / why we need it: This PR enables PID namespace sharing for docker pods by default, bringing the behavior of docker in line with the other CRI runtimes when used with docker >= 1.13.1.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): ref #1615Special notes for your reviewer: cc @dchen1107 @yujuhong
Release note: