Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-restful dependency #45390

Merged
merged 1 commit into from
May 5, 2017
Merged

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented May 4, 2017

This is required by #44787. But because both this and the changes in 44787 need constant rebase, I am trying to get this one in separately to make less rebases.

The change is only a dependency update.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@mbohlool mbohlool added the release-note-none Denotes a PR that doesn't merit a release note. label May 5, 2017
@k8s-github-robot k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 5, 2017
@@ -34703,35 +34703,6 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.


================================================================================
= vendor/github.com/emicklei/go-restful/swagger licensed under: =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does go-restful-swagger12 not have a license?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mbohlool
Copy link
Contributor Author

mbohlool commented May 5, 2017

@k8s-bot bazel test this

@lavalamp
Copy link
Member

lavalamp commented May 5, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, mbohlool

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2017
@mbohlool
Copy link
Contributor Author

mbohlool commented May 5, 2017

Applying P1 because the PR needs rebase frequently.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2017
@mbohlool mbohlool force-pushed the c4 branch 3 times, most recently from e3804ff to af56d71 Compare May 5, 2017 18:52
@mbohlool
Copy link
Contributor Author

mbohlool commented May 5, 2017

@k8s-bot test this

@mbohlool mbohlool added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43006, 45305, 45390, 45412, 45392)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants