Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addon-resizer version #46850

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Update addon-resizer version #46850

merged 1 commit into from
Jun 29, 2017

Conversation

x13n
Copy link
Member

@x13n x13n commented Jun 2, 2017 •
edited by piosz
Loading

Update addon-resizer version and remove the flags that have been deprecated in the new version.

What this PR does / why we need it:
ref kubernetes-retired/contrib#2623

Special notes for your reviewer:
Need to wait for merging kubernetes-retired/contrib#2623 first.

Release note:
addon-resizer flapping behavior was removed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 2, 2017
@x13n
Copy link
Member Author

x13n commented Jun 2, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@piosz
Copy link
Member

piosz commented Jun 2, 2017

ping me once the new version is out.

@x13n
Copy link
Member Author

x13n commented Jun 9, 2017

Just talked to @mwielgus: nanny will be moved from contrib to autoscaler and only after that my changes (incl. version bump) will be applied. I'm away next week, so new version won't be there probably for 2 more weeks.

@piosz
Copy link
Member

piosz commented Jun 13, 2017

no worries.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2017
@piosz
Copy link
Member

piosz commented Jun 23, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2017
@x13n
Copy link
Member Author

x13n commented Jun 23, 2017

/test pull-kubernetes-e2e-gce-etcd3

@mwielgus mwielgus added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 23, 2017
@mwielgus
Copy link
Contributor

Please wait until the 1.7 release is cut to prevent accidental inclusion in 1.7. This has a potential to screw up lots of things at the very last minute.

@mwielgus mwielgus removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@piosz
Copy link
Member

piosz commented Jun 23, 2017

I doesn't have 1.7 milestone and at the same time the code free has been lifted.

@x13n
Copy link
Member Author

x13n commented Jun 23, 2017

Relevant communication: https://groups.google.com/forum/#!topic/kubernetes-dev/JtOV38Gl3ng

@x13n
Copy link
Member Author

x13n commented Jun 26, 2017

@mwielgus How long would you like to wait exactly, given that code freeze was lifted on Jun 22?

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2017
@x13n
Copy link
Member Author

x13n commented Jun 27, 2017

@mwielgus @piosz ping

@piosz
Copy link
Member

piosz commented Jun 28, 2017

@x13n you need to rebase. I think we are definitely ready to merge, since 1.7 is about to be released today.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 28, 2017
@x13n
Copy link
Member Author

x13n commented Jun 29, 2017

There is no point in rebasing, if noone is going to merge it. @piosz @mwielgus

@x13n
Update addon-resizer version
63ccedc 
Also, remove the flags that have been deprecated in the new version.
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2017
@piosz
Copy link
Member

piosz commented Jun 29, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piosz, x13n

Associated issue: 2623

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@piosz piosz removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 29, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46850, 47984)

@k8s-github-robot k8s-github-robot merged commit d3aa0d5 into kubernetes:master Jun 29, 2017
@k8s-ci-robot
Copy link
Contributor

@x13n: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 63ccedc link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@x13n
Copy link
Member Author

x13n commented Jun 29, 2017

/retest

@x13n x13n deleted the nanny-version branch June 29, 2017 15:38
@piosz piosz mentioned this pull request Sep 15, 2017
Closed
@aleksandra-malinowska aleksandra-malinowska mentioned this pull request Sep 15, 2017
Merged
@piosz piosz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 15, 2017
@piosz
Copy link
Member

piosz commented Sep 15, 2017

Updated release notes as this will be reverted in #52536

cc @aleksandra-malinowska

k8s-github-robot pushed a commit that referenced this pull request Sep 15, 2017
Merge pull request #52536 from aleksandra-malinowska/revert-update-ad…
d7770f9 
…don-resizer-version

Automatic merge from submit-queue

Revert "Update addon-resizer version"

This reverts #46850 due to several issues with new version of addon resizer (#50599, #52535), as recommended by @piosz. 

cc @fgrzadkowski @x13n
squat pushed a commit to squat/tectonic-installer that referenced this pull request Sep 25, 2017
@Quentin-M @squat
modules/tectonic/resources/manifests/heapster: remove threshold/estim…
320f29f 
…ator

Ref: kubernetes/kubernetes#46850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@x13n @piosz @mwielgus @k8s-github-robot @k8s-ci-robot @DirectXMan12