-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fieldSelector podIP #50091
add fieldSelector podIP #50091
Conversation
@dixudx: GitHub didn't allow me to request PR reviews from the following users: LiliC. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @dixudx. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test /lgtm |
/test pull-kubernetes-e2e-gce-etcd3 |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dixudx, justinsb Associated issue: 50075 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 50091, 50231, 50238, 50236, 50243) |
@dixudx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
How come this was not included in 1.7.4? Is it related to the test failure above or did it just get merged too late? |
@asymmetric You can rebase this PR into |
I don't think this should be cherrypicked. This is not a bug fix - it's a feature. |
@asymmetric Prefer to rebuild Cherry-pick this PR into your desired Kubernetes version and |
What this PR does / why we need it:
Currently the
fieldSelector
forPod
only supportmetadata.name
,metadata.namespace
,spec.nodeName
,spec.restartPolicy
andstatus.phase
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #50075Special notes for your reviewer:
/cc @wojtek-t @caesarxuchao @justinsb @lilic
Release note: