Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for updating quota on update #52452

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Fix support for updating quota on update #52452

merged 1 commit into from
Sep 15, 2017

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Sep 13, 2017 •
edited
Loading

This PR implements support for properly handling quota when resources are updated. We never take negative values and add them up.

Fixes #51736

cc @derekwaynecarr

/sig storage

Make sure that resources being updated are handled correctly by Quota system

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 13, 2017
@gnufied gnufied force-pushed the fix-quota-on-update branch from df25153 to 5ade409 Compare September 13, 2017 22:21
@gnufied gnufied force-pushed the fix-quota-on-update branch from 5ade409 to 066fcf7 Compare September 14, 2017 01:06
@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2017

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-bazel
/test pull-kubernetes-federation-e2e-gce

@gnufied gnufied changed the title Implement support for updating quota on update Fix support for updating quota on update Sep 14, 2017
@derekwaynecarr
Copy link
Member

this is a critical fix to ensure that resizing storage cannot game quota.

i am adding to the 1.8 milestone, but i will need to do a deeper code review later today.

@derekwaynecarr derekwaynecarr added this to the v1.8 milestone Sep 14, 2017
@derekwaynecarr
Copy link
Member

the code looks good, thanks for following up on this!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, gnufied

Associated issue: 51736

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2017
@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2017

/test pull-kubernetes-e2e-gce-bazel

@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2017

/retest

@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2017

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-bazel

@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2017

/test pull-kubernetes-e2e-gce-bazel

2 similar comments
@gnufied
Copy link
Member Author

gnufied commented Sep 15, 2017

/test pull-kubernetes-e2e-gce-bazel

@gnufied
Copy link
Member Author

gnufied commented Sep 15, 2017

/test pull-kubernetes-e2e-gce-bazel

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52452, 52115, 52260, 52290)

@k8s-github-robot k8s-github-robot merged commit 935726f into kubernetes:master Sep 15, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 15, 2017 •
edited
Loading

@gnufied: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 066fcf7 link /test pull-kubernetes-e2e-gce-bazel
pull-kubernetes-unit 066fcf7 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@gnufied @derekwaynecarr @k8s-github-robot @k8s-ci-robot @smarterclayton