Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh scheduler equivalence cache when node taints changed. #53480

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Refresh scheduler equivalence cache when node taints changed. #53480

merged 1 commit into from
Oct 6, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Oct 5, 2017

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #53425

Release note:

None

@k82cn k82cn self-assigned this Oct 5, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/test ci-kubernetes-e2e-gci-gce-alpha-features

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/test pull-kubernetes-e2e-gke-gpu

@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/test pull-kubernetes-e2e-gci-gce-alpha-features

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2017
@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/test pull-kubernetes-e2e-gke-gpu

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/test pull-kubernetes-e2e-gke-gpu

@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/retest

@k82cn k82cn changed the title [WIP] Fixed alpha e2e test failure. Refresh scheduler equivalence cache when node taints changed. Oct 5, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2017
@k82cn k82cn mentioned this pull request Oct 5, 2017
Closed
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

/assign @resouer @bsalamat

It seems PodToleratesNodeTaints was not enabled in test environment, and after TaintNodeByCondition, it's mandatory. Open #53486 to trace the discussion to enable all predicate/priority in this env.

@k82cn k82cn removed their assignment Oct 5, 2017
@k82cn k82cn mentioned this pull request Oct 5, 2017
Closed
@k82cn
Copy link
Member Author

k82cn commented Oct 5, 2017

xref #53399

@k82cn
Copy link
Member Author

k82cn commented Oct 6, 2017

ping :).

@bsalamat
Copy link
Member

bsalamat commented Oct 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, k82cn

Associated issue: 53425

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fe5c628 into kubernetes:master Oct 6, 2017
@k82cn k82cn deleted the k8s_53425 branch October 6, 2017 12:21
@k82cn k82cn mentioned this pull request Oct 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@resouer resouer

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci-kubernetes-e2e-gci-gce-alpha-features is failing
5 participants
@k82cn @bsalamat @k8s-github-robot @resouer @k8s-ci-robot