-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HugePages feature is beta in 1.10 release #56939
HugePages feature is beta in 1.10 release #56939
Conversation
/cc |
@tianshapjq: GitHub didn't allow me to request PR reviews from the following users: tianshapjq. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@derekwaynecarr what has changed between the 1.9 release and now to make this qualify for beta? If we have additional work planned, it feels like we should wait until its done. If we don't have additional work planned, why wait to 1.10? |
@brendandburns HugePages work tracker, maybe this is the work plan for 1.10. |
Looked at the work tracker, let's merge this once the other two items in the beta list are merged... |
@brendanburns -- i held this pending merge of #54379 |
@brendandburns -- prerequisite pr has merged, this should be good to go. |
/lgtm |
/test all Tests are more than 96 hours old. Re-running tests. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, dchen1107, derekwaynecarr, spiffxp Associated issue: #53672 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 57906, 57425, 56939, 57317, 57762). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Graduate support of HugePages to beta.
Which issue(s) this PR fixes
Fixes #53672
Special notes for your reviewer: