-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for LeaderElect for kube-scheduler #60524
Temporary fix for LeaderElect for kube-scheduler #60524
Conversation
kube-controller-manager defaults --leader-elect to true. We should do the same for kube-scheduler. kube-scheduler used to have this set to true, but it got lost during refactoring: efb2bb7
cc @kubernetes/sig-scheduling-pr-reviews |
/lgtm needs cherry-pick to 1.9, right? |
/retest |
/status approve-for-milestone |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dims We need to do cherry pick now |
This isn't merging because it doesn't have status/approved-for-milestone. |
this is a bugfix that is required for 1.10 and in process to be backported to 1.9 |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process @bsalamat @dims @liggitt @mtaufen Pull Request Labels
|
/test all [submit-queue is verifying that this PR is safe to merge] |
/test pull-kubernetes-bazel-build |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test pull-kubernetes-integration |
#60614 |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
/approve |
…pstream-release-1.9 Automated cherry pick of #60524: Temporary fix for LeaderElect for kube-scheduler
What this PR does / why we need it:
kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring:
efb2bb7
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #59729
Special notes for your reviewer:
Release note: