generated code should pass go vet for go1.10

[bhcleek]

What this PR does / why we need it:

Update code generator and the code it generates to pass go vet.

go1.10 runs go vet whenever go test is run. Because of this, generated code for CRDs needs to pass go vet.

Release note:

Code generated for CRDs now passes `go vet`.

[bhcleek]

/sig api-machinery
/area custom-resources

[cblecker]

/ok-to-test
/cc @sttts

[sttts]

lgtm when it's green
/approve

[cblecker]

/retest

[wenjiaswe]

cc @roycaihw

[roycaihw]

Please run make update to regenerate the code for other packages as well.

   M pkg/client/clientset_generated/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/examples/client-go/pkg/client/clientset/versioned/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/pkg/client/clientset/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/client-go/kubernetes/fake/clientset_generated.go
   M staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/metrics/pkg/client/clientset_generated/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/sample-apiserver/pkg/client/clientset/internalversion/fake/clientset_generated.go
   M staging/src/k8s.io/sample-apiserver/pkg/client/clientset/versioned/fake/clientset_generated.go
   M staging/src/k8s.io/sample-controller/pkg/client/clientset/versioned/fake/clientset_generated.go

lgtm when tests are green

[roycaihw]

/assign

[bhcleek]

/retest

[cblecker]

/test pull-kubernetes-bazel-test

[bhcleek]

The bazel test failures are valid. I'm working on fixing them now.

[roycaihw]

/lgtm

[sttts]

/assign @deads2k
/assign @DirectXMan12

for approval.

[deads2k]

/approve
/hold

holding to squash all that generated code into one "generated" commit.

[bhcleek]

I rebased to reduce the number of commits; all regenerated fakes are now in a single commit.

[bhcleek]

/test pull-kubernetes-e2e-gce-device-plugin-gpu

[deads2k]

/approve
/hold cancel

[deads2k]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bhcleek, deads2k, roycaihw, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/client/OWNERS [deads2k]
• staging/src/k8s.io/apiextensions-apiserver/OWNERS [deads2k,sttts]
• staging/src/k8s.io/client-go/OWNERS [deads2k,sttts]
• staging/src/k8s.io/code-generator/OWNERS [sttts]
• staging/src/k8s.io/kube-aggregator/OWNERS [deads2k]
• staging/src/k8s.io/metrics/OWNERS
• staging/src/k8s.io/sample-apiserver/OWNERS [deads2k,sttts]
• staging/src/k8s.io/sample-controller/OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

it's just the generated expression in metrics. tagging.

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.