Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodeport repair for ESIPP services #64349

Merged
merged 1 commit into from
May 28, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented May 25, 2018

What this PR does / why we need it:
The nodeport allocation repair controller does not scrape the Service.Spec.healthCheckNodePort value and would remove the allocation from memory and etcd after 10 minutes. This opens the door for other services to use the same nodeport and cause collisions.

Which issue(s) this PR fixes:
Fixes #54885

Release note:

Fix issue of colliding nodePorts when the cluster has services with externalTrafficPolicy=Local

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2018
@nicksardo
Copy link
Contributor Author

/cc @bowei

@k8s-ci-robot k8s-ci-robot requested a review from bowei May 25, 2018 23:19
@nicksardo
Copy link
Contributor Author

/assign wojtek-t
/uncc caesarxuchao

@k8s-ci-robot k8s-ci-robot removed the request for review from caesarxuchao May 25, 2018 23:50
@bowei
Copy link
Member

bowei commented May 26, 2018

/cc @MrHohn
/lgtm

@k8s-ci-robot k8s-ci-robot requested a review from MrHohn May 26, 2018 00:00
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2018
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2018
@wojtek-t
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 28, 2018

@nicksardo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu c05e89d link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@nicksardo
Copy link
Contributor Author

After upgrading to a version with this fix, all services with overlapping nodeports will see events such as

Events:
  Type     Reason                Age              From                             Message
  ----     ------                ----             ----                             -------
  Warning  PortAlreadyAllocated  2m (x3 over 5m)  portallocator-repair-controller  Port 32457 was assigned to multiple services; please recreate service

k8s-github-robot pushed a commit that referenced this pull request May 30, 2018
…349-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64349: Fix nodeport repair for ESIPP services

Cherry pick of #64349 on release-1.10.

#64349: Fix nodeport repair for ESIPP services
k8s-github-robot pushed a commit that referenced this pull request Jun 4, 2018
Automatic merge from submit-queue.

Fix nodeport repair for ESIPP services

**What this PR does / why we need it**:
The nodeport allocation repair controller does not scrape the `Service.Spec.healthCheckNodePort` value and would remove the allocation from memory and etcd after 10 minutes.  This opens the door for other services to use the same nodeport and cause collisions. 

**Which issue(s) this PR fixes**:
Fixes #54885
Similar to #64349

**Release note**:
```release-note
Fix issue of colliding nodePorts when the cluster has services with externalTrafficPolicy=Local
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Nodeport and Healthcheck Nodeport Collision
5 participants