Fix locating resourcepool-path specified in the vsphere.conf file #66261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
divyenpatel
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, SandeepPissay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BaluDontu
approved these changes
Jul 17, 2018
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Jul 17, 2018
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 20, 2018
…-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #66261 to upstream release-1.10 Cherry pick of #66261 on release-1.10 #66261: Fix locating resourcepool-path specified in the vsphere.conf file Release note: ``` Fix locating resourcepool-path specified in the vsphere.conf file ``` cc: @kubernetes/vmware
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 25, 2018
…-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #66261 to upstream release-1.9 Cherry pick of #66261 on release-1.9 #66261: Fix locating resourcepool-path specified in the vsphere.conf file Release note: ``` Fix locating resourcepool-path specified in the vsphere.conf file ``` cc: @kubernetes/vmware
|
/sig vmware |
k8s-ci-robot
added
the
area/provider/vmware
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 2, 2018
…-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #66261 to upstream release-1.11 Cherry pick of #66261 on release-1.11 #66261: Fix locating resourcepool-path specified in the vsphere.conf file Release note: ``` Fix locating resourcepool-path specified in the vsphere.conf file ``` cc: @kubernetes/vmware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When volume is provisioned using the vsphere storage policy,
resourcepool-pathspecified in thevsphere.conffile is used for creating a shadow/dummy VM. Dummy VM is temporarily created and then deleted once volume is created on the compatible Datastore.At present If user specifies
resourcepool-pathin thevsphere.conffile, volume provisioner is not able to locate the compute resource for the given path. This is because look up is made usingfinder.DefaultComputeResource(ctx)andfinder.ComputeResource(ctx, computePath), which is not correct. If user specifies name of the cluster or cluster path then provisioning works.This is resolved with using correct govmomi method -
func (f *Finder) ResourcePoolOrDefault(ctx context.Context, path string) (*object.ResourcePool, error)Which issue(s) this PR fixes
Fixes # vmware-archive#493
Special notes for your reviewer:
Following testing is performed for this change.
vsphere.conffile and verified VM is created under the specified resource pool.vsphere.conffile and verified volume provisioning works. For this case, VM is directly created under cluster.As expected, provisioning is failing with
Failed to provision volume with StorageClass "vsan-gold-policy": no default resource pool found.Refer to this datacenter inventory for the path specified in the
resourcepool-pathconfiguration.Current documentation describes
resourcepool-pathconfiguration is optional, which needs to be corrected once PR is merged. For policy based provisioning this is not an optional parameter.Documentation link: https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/existing.html
Release note:
cc: @kubernetes/vmware