Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for disabled legacy metadata endpoints #69593

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

dekkagaijin
Copy link
Contributor

@dekkagaijin dekkagaijin commented Oct 9, 2018

What this PR does / why we need it:

GCE allows for users to disable access to legacy (0.1, v1beta1) metadata APIs from within an instance. GKE disables these by default for new 1.12+ clusters. This check allows for the test to know when it should expect a 403 from an unconcealed legacy metadata endpoint.

NONE

Signed-off-by: Jake Sanders <jsand@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2018
@k8s-ci-robot k8s-ci-robot requested review from luxas and mkumatag October 9, 2018 20:47
@dekkagaijin
Copy link
Contributor Author

@mikedanese PTAL, this should fix the tests for 1.12

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2018
@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkagaijin, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 18, 2018
@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2018
@mikedanese mikedanese added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit fecaa54 into kubernetes:master Oct 23, 2018
@idealhack
Copy link
Member

I guess a PR should be opened to cherry-pick this to 1.12?

@dekkagaijin dekkagaijin deleted the legacy-metadata-test branch October 23, 2018 22:49
@dekkagaijin
Copy link
Contributor Author

@idealhack will do

@ixdy
Copy link
Member

ixdy commented Oct 23, 2018

I think for this to have any effect, you need to bump the version in test/images/metadata-concealment/VERSION, then run make -C test/images all-push WHAT=metadata-concealment (from a machine with docker 18.06.0+) and then update test/utils/image/manifest.go to point to the new version.

@ixdy
Copy link
Member

ixdy commented Oct 23, 2018

@mkumatag I'm forgetting, do we have docs anywhere describing how to update e2e test images? If not, we should probably write some.

@mkumatag
Copy link
Member

@mkumatag I'm forgetting, do we have docs anywhere describing how to update e2e test images? If not, we should probably write some.

lemme create a GitHub issue right away - #70165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants