-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for disabled legacy metadata endpoints #69593
account for disabled legacy metadata endpoints #69593
Conversation
Signed-off-by: Jake Sanders <jsand@google.com>
@mikedanese PTAL, this should fix the tests for 1.12 |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dekkagaijin, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
I guess a PR should be opened to cherry-pick this to 1.12? |
@idealhack will do |
I think for this to have any effect, you need to bump the version in |
@mkumatag I'm forgetting, do we have docs anywhere describing how to update e2e test images? If not, we should probably write some. |
What this PR does / why we need it:
GCE allows for users to disable access to legacy (0.1, v1beta1) metadata APIs from within an instance. GKE disables these by default for new 1.12+ clusters. This check allows for the test to know when it should expect a 403 from an unconcealed legacy metadata endpoint.