Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kubectl run to generate apps/v1 deployments #71006

Merged
merged 1 commit into from
Nov 14, 2018
Merged

update kubectl run to generate apps/v1 deployments #71006

merged 1 commit into from
Nov 14, 2018
+104 −5

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 13, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

moves default kubectl deployment generation behavior to the stable apps/v1 API

extracted from #70370 for easier review

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #43214

Does this PR introduce a user-facing change?:

kubectl run now generates apps/v1 deployments by default

/sig cli
/sig apps

@liggitt liggitt requested a review from soltysh November 13, 2018 19:41
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 13, 2018
@liggitt liggitt mentioned this pull request Nov 13, 2018
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 13, 2018

/milestone v1.13
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 13, 2018
soltysh
soltysh approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit d00cb23 into kubernetes:master Nov 14, 2018
@liggitt liggitt deleted the kubectl-run-apps-v1 branch November 14, 2018 00:42
@sluetze sluetze mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @k8s-ci-robot @soltysh