Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find current resourceVersion for waiting for deletion/conditions #72825

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 11, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Does a filtered list to get the current object and current resource version when waiting for deletion or for a condition

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubectl: fixed an issue with "too old resource version" errors continuously appearing when calling `kubectl delete`

/cc @deads2k

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot requested a review from deads2k January 11, 2019 15:40
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2019
@liggitt
Copy link
Member Author

liggitt commented Jan 11, 2019

/kind bug
/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2019
@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 11, 2019
@deads2k
Copy link
Contributor

deads2k commented Jan 11, 2019

optional nit, lgtm otherwise

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the wait-resource-version branch from 50952d8 to c12d8a5 Compare January 11, 2019 20:24
@liggitt
Copy link
Member Author

liggitt commented Jan 11, 2019

resolved nit, tagging

@fedebongio
Copy link
Contributor

/cc @jpbetz

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz January 14, 2019 21:08
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2019
…5-upstream-release-1.12

Automated cherry pick of #72825: Find current resourceVersion for waiting for
k8s-ci-robot added a commit that referenced this pull request Jan 15, 2019
…5-upstream-release-1.13

Automated cherry pick of #72825: Find current resourceVersion for waiting for
k8s-ci-robot added a commit that referenced this pull request Jan 17, 2019
…5-upstream-release-1.11

Automated cherry pick of #72825: Find current resourceVersion for waiting for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants