Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark rules field as optional #73250

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Mark rules field as optional #73250

merged 1 commit into from
Feb 1, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
The rules lists in RBAC Role/ClusterRole objects are not required. Marking them as optional allows manifests without them present to be submitted without kubectl complaining. Note that this doesn't change serialization in any way.

Which issue(s) this PR fixes:
Fixes #73050

Does this PR introduce a user-facing change?:

The `rules` field in RBAC Role and ClusterRole objects is now correctly reported as optional in the openapi schema.

/sig auth

@liggitt liggitt requested a review from deads2k January 24, 2019 05:01
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jan 24, 2019
@liggitt liggitt mentioned this pull request Jan 24, 2019
Closed
@dims
Copy link
Member

dims commented Feb 1, 2019

The work around is ugly ( #73050 (comment) ), yes, let's please get this in.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 46b2255 into kubernetes:master Feb 1, 2019
@liggitt liggitt deleted the optional-rules branch February 5, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregated ClusterRole validation is incompatible with kubectl apply
3 participants
@liggitt @k8s-ci-robot @dims