-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apiextensions to client's scheme #73720
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: soltysh If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1b7a720
to
0e5e6ca
Compare
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The register.go is generated. Apiextension clients are intentionally not included in client-go. See kubernetes/client-go#247 (comment). You can use the clientset from the apiextension repo. |
That's fair, thanks for the info and pointers. |
@soltysh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When client is interacting with kubernetes API it should have the ability to us all the possible resources. For some reason we were missing CRD's definition in scheme. This PR fills that gap.
Special notes for your reviewer:
/assign @deads2k @sttts
Does this PR introduce a user-facing change?: