fix negative slice index error in keymutex in 1.13 #74386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/assign @aleksandra-malinowska |
danielqsj
changed the title
|
/cc @apelisse |
|
/sig storage |
k8s-ci-robot
added
sig/storage
aleksandra-malinowska
added
cherry-pick-approved
|
Please get approve and LGTM as for any other PR. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @thockin |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, danielqsj, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 28, 2019
…386-upstream-release-1.12 Automated cherry pick of #74386: fix negative slice index error in keymutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This issue #73858 report that the generated index for slice in
keymutexmaybe negative in some platform (like arm).This PR aims to fix this issue.
Which issue(s) this PR fixes:
Fixes #73858
Special notes for your reviewer:
Already fixed it in master branch by kubernetes/utils#84.
But in before
1.14, keymutex code is in k/k, so I submit this PR to fix it in1.13, and then will cherrypick to1.12.Does this PR introduce a user-facing change?: