Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndpointSlice Controller #81048

Merged
merged 1 commit into from
Aug 29, 2019
Merged

EndpointSlice Controller #81048

merged 1 commit into from
Aug 29, 2019

Conversation

robscott
Copy link
Member

@robscott robscott commented Aug 6, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds an EndpointSlice Controller for the new Discovery API Group, building on the earlier PR here: #80766.

Special notes for your reviewer:
Until the PR this is built on gets merged in, the diff specific to this PR can be found here: robscott/kubernetes@discovery-api...robscott:endpointslice-controller

Does this PR introduce a user-facing change?:

Adds Endpoint Slice Controller for managing new EndpointSlice resource, disabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @robscott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott changed the title Endpointslice controller EndpointSlice Controller Aug 6, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 6, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@freehan freehan self-assigned this Aug 6, 2019
@freehan
Copy link
Contributor

freehan commented Aug 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2019
@freehan freehan added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 6, 2019
@robscott robscott force-pushed the endpointslice-controller branch from ca48e8a to d259a9b Compare August 7, 2019 16:47
@robscott
Copy link
Member Author

robscott commented Aug 7, 2019

/retest

3 similar comments
@robscott
Copy link
Member Author

robscott commented Aug 7, 2019

/retest

@robscott
Copy link
Member Author

robscott commented Aug 7, 2019

/retest

@robscott
Copy link
Member Author

robscott commented Aug 7, 2019

/retest

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2019
@robscott
Copy link
Member Author

/retest

@robscott robscott force-pushed the endpointslice-controller branch from 54c950b to fc94770 Compare August 27, 2019 20:07
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@robscott
Copy link
Member Author

/retest

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@robscott
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@robscott robscott force-pushed the endpointslice-controller branch from fc94770 to f97c3aa Compare August 29, 2019 01:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@robscott robscott force-pushed the endpointslice-controller branch 2 times, most recently from 1fb8c6b to 32201ce Compare August 29, 2019 02:44
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member

thockin commented Aug 29, 2019 via email

@robscott robscott force-pushed the endpointslice-controller branch from 32201ce to 75f6c24 Compare August 29, 2019 04:13
@Katharine
Copy link
Member

/test pull-kubernetes-bazel-test

@thockin thockin mentioned this pull request Aug 29, 2019
Merged
@thockin
Copy link
Member

thockin commented Aug 29, 2019

/lgtm

Why is this held?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@robscott
Copy link
Member Author

Initially was trying to get a bit more into this PR but decided to pull that out into another one, then had to rebase on dual stack changes. Should have that other PR ready soon.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7da9bdc into kubernetes:master Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@robscott robscott mentioned this pull request Sep 12, 2019
Closed
6 tasks
@ialidzhikov ialidzhikov mentioned this pull request Aug 19, 2020
Merged
@robscott robscott deleted the endpointslice-controller branch March 11, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khenidak khenidak khenidak left review comments

@imroc imroc imroc left review comments

@thockin thockin thockin left review comments

@freehan freehan freehan left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@freehan freehan

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
10 participants
@robscott @k8s-ci-robot @fejta-bot @freehan @fedebongio @cblecker @thockin @Katharine @imroc @khenidak