Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow automatic ACR auth in private Azure clouds #90425

Merged
merged 1 commit into from
Apr 25, 2020
Merged

fix: Allow automatic ACR auth in private Azure clouds #90425

merged 1 commit into from
Apr 25, 2020

Conversation

DavidParks8
Copy link
Contributor

@DavidParks8 DavidParks8 commented Apr 23, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Provides a fix to allow a cluster in a private Azure cloud to authenticate to ACR in the same cloud.

Which issue(s) this PR fixes:
Fixes #90412

Does this PR introduce a user-facing change?:
NONE

Provides a fix to allow a cluster in a private Azure cloud to authenticate to ACR in the same cloud.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @DavidParks8!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @DavidParks8. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2020
@DavidParks8
Copy link
Contributor Author

/area provider/azure
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2020
@jackfrancis
Copy link
Contributor

@feiskyer @andyzhangx PTAL

@andyzhangx
Copy link
Member

/ok-to-test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 24, 2020
@DavidParks8
Copy link
Contributor Author

/retest

@DavidParks8
Copy link
Contributor Author

/retest

@DavidParks8
Copy link
Contributor Author

@andyzhangx can I please get an official lgtm now that the flakey tests have passed? I will also need this change squash merged because I do not have merge rights. Thanks for your time!

@andyzhangx
Copy link
Member

@andyzhangx can I please get an official lgtm now that the flakey tests have passed? I will also need this change squash merged because I do not have merge rights. Thanks for your time!

can you squash the commits first? thanks

@DavidParks8
Copy link
Contributor Author

Squashed.

andyzhangx
andyzhangx approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, DavidParks8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx
Copy link
Member

BTW, this PR is for Azure stack, right? @DavidParks8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2020
@DavidParks8
Copy link
Contributor Author

The PR is for private Azure clouds, including Azure stack.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
@k8s-ci-robot
Copy link
Contributor

@DavidParks8: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 333b049 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DavidParks8
Copy link
Contributor Author

/test pull-kubernetes-e2e-aks-engine-azure

feiskyer
feiskyer approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 40cb93b into kubernetes:master Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 25, 2020
@DavidParks8 DavidParks8 deleted the daparks/fixacrauth branch April 25, 2020 03:50
This was referenced Apr 25, 2020
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 11, 2020
@k8s-ci-robot
Merge pull request #90480 from andyzhangx/automated-cherry-pick-of-#9…
4094932 
…0425-upstream-release-1.16

Automated cherry pick of #90425: fix: ACR auth fails in private azure clouds
k8s-ci-robot added a commit that referenced this pull request May 11, 2020
@k8s-ci-robot
Merge pull request #90479 from andyzhangx/automated-cherry-pick-of-#9…
2db6ec1 
…0425-upstream-release-1.17

Automated cherry pick of #90425: fix: ACR auth fails in private azure clouds
k8s-ci-robot added a commit that referenced this pull request May 11, 2020
@k8s-ci-robot
Merge pull request #90478 from andyzhangx/automated-cherry-pick-of-#9…
209a8b0 
…0425-upstream-release-1.18

Automated cherry pick of #90425: fix: ACR auth fails in private azure clouds
@andyzhangx andyzhangx mentioned this pull request Jul 1, 2020
Closed
@feiskyer feiskyer mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@feiskyer feiskyer feiskyer approved these changes

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@feiskyer feiskyer

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Azure credential provider does not authenticate to ACR in all clouds
6 participants
@DavidParks8 @k8s-ci-robot @jackfrancis @andyzhangx @chewong @feiskyer