Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop batch/v2alpha1 #96987

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Drop batch/v2alpha1 #96987

merged 2 commits into from
Feb 17, 2021

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 1, 2020 •
edited by liggitt
Loading

What type of PR is this?

/kind cleanup
/kind api-change
/kind deprecation

What this PR does / why we need it:
This is part of the work related with promoting CronJobs to GA. See kubernetes/enhancements#19

Special notes for your reviewer:
/assign @liggitt @deads2k

Does this PR introduce a user-facing change?:

The `batch/v2alpha1` CronJob type definitions and clients are deprecated and removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 1, 2020
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Dec 1, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 12, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 15, 2021

/retest

@soltysh soltysh changed the title [WIP] Drop batch/v2alpha1 Drop batch/v2alpha1 Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 15, 2021

/test pull-kubernetes-e2e-gce-100-performance

@soltysh soltysh mentioned this pull request Feb 15, 2021
Merged
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 15, 2021

/retest

2 similar comments
@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2021

/retest

@liggitt
Copy link
Member

liggitt commented Feb 16, 2021

/retest

@liggitt
Copy link
Member

liggitt commented Feb 16, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2021

/hold
I think there are still some leftovers in the infra. I'll look for them.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021
@soltysh soltysh mentioned this pull request Feb 17, 2021
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Feb 17, 2021

/retest

1 similar comment
@soltysh
Copy link
Contributor Author

soltysh commented Feb 17, 2021

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Feb 17, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4f1dd5d into kubernetes:master Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2021
@soltysh soltysh deleted the drop_batch-alpha branch February 17, 2021 15:15
@spiffxp
Copy link
Member

spiffxp commented Feb 17, 2021 •
edited
Loading

The perception that updating release-branch job configs (kubernetes/test-infra#20879) is what allowed this to merge felt really wrong to me. Did some digging.

What actually allowed these to pass wasn't just removing the explicit --runtime-config=batch/v2alpha1=true flags from job configs, but also removing the (poorly chosen) default of batch/v2alpha1=true hardcoded into kubetest (ref: https://github.com/kubernetes/test-infra/pull/20865/files#diff-71dd7bf85cfecc6c2c2fa0956ad5f182433bcc0f287aaa83f2052eb3f8ba9710L175)

Changes to kubetest don't take effect until a new kubekins image is built and job configs are updated to use the new image.

kubernetes/test-infra#20852 is the PR that bumped job configs to the kubekins image including the kubetest change. It merged about 20 hours ago. This lines up with when the jobs started passing.

tl;dr release-branch job changes had nothing to do with it, they just happened to land near the time the kubestest changes were actually rolled out

@spiffxp
Copy link
Member

spiffxp commented Feb 17, 2021

Changes to kubetest don't take effect until a new kubekins image is built and job configs are updated to use the new image

This needs to be made clearer. We roll out changes this way to allow someone to canary kubetest changes before they roll out to all jobs. @liggitt suggested having kubetest print out its version

@BenTheElder
Copy link
Member

+1, but besides printing version I recommend recording it to an artifact. Kind does this when log dumping and it's been super useful.

@spiffxp spiffxp mentioned this pull request Feb 17, 2021
Closed
@spiffxp
Copy link
Member

spiffxp commented Feb 17, 2021 •
edited
Loading

Opened kubernetes/test-infra#20886 to cover how to make it clear which version is being used

@kendallroden kendallroden mentioned this pull request Feb 24, 2021
Closed
16 tasks
@ialidzhikov ialidzhikov mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
7 participants
@soltysh @fedebongio @fejta-bot @liggitt @k8s-ci-robot @spiffxp @BenTheElder