Skip to content

Commit

Permalink
Merge pull request #3982 from tstromberg/more-log-pods
Browse files Browse the repository at this point in the history
Add addon-manager, dashboard, and storage-provisioner to minikube logs
  • Loading branch information
tstromberg authored Mar 26, 2019
2 parents 10e4981 + 48e4808 commit 2cd7ab3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 0 additions & 3 deletions pkg/minikube/cruntime/cruntime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,6 @@ func TestContainerFunctions(t *testing.T) {
"fgh1": prefix + "coredns",
"xyz2": prefix + "storage",
}
if tc.runtime == "docker" {
runner.containers["zzz"] = "unrelated"
}
cr, err := New(Config{Type: tc.runtime, Runner: runner})
if err != nil {
t.Fatalf("New(%s): %v", tc.runtime, err)
Expand Down
4 changes: 0 additions & 4 deletions pkg/minikube/cruntime/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ import (
"github.com/golang/glog"
)

// KubernetesContainerPrefix is the prefix of each kubernetes container
const KubernetesContainerPrefix = "k8s_"

// Docker contains Docker runtime state
type Docker struct {
Socket string
Expand Down Expand Up @@ -99,7 +96,6 @@ func (r *Docker) KubeletOptions() map[string]string {

// ListContainers returns a list of containers
func (r *Docker) ListContainers(filter string) ([]string, error) {
filter = KubernetesContainerPrefix + filter
content, err := r.Runner.CombinedOutput(fmt.Sprintf(`docker ps -a --filter="name=%s" --format="{{.ID}}"`, filter))
if err != nil {
return nil, err
Expand Down
3 changes: 3 additions & 0 deletions pkg/minikube/logs/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ var importantPods = []string{
"coredns",
"kube-scheduler",
"kube-proxy",
"kube-addon-manager",
"kubernetes-dashboard",
"storage-provisioner",
}

// lookbackwardsCount is how far back to look in a log for problems. This should be large enough to
Expand Down

0 comments on commit 2cd7ab3

Please sign in to comment.