Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix registry addon for containerd runtime. #10778

Closed
medyagh opened this issue Mar 10, 2021 · 1 comment · Fixed by #10782
Closed

fix registry addon for containerd runtime. #10778

medyagh opened this issue Mar 10, 2021 · 1 comment · Fixed by #10782
Assignees
Labels
co/runtime/containerd co/runtime/crio CRIO related issues kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

Our Registry addon is not working on Containerd

https://storage.googleapis.com/minikube-builds/logs/10758/9ba6c7c/Docker_Linux_containerd.html#fail_TestAddons%2fparallel%2fRegistry

=== RUN   TestAddons/parallel/Registry
=== PAUSE TestAddons/parallel/Registry
=== CONT  TestAddons/parallel/Registry
=== CONT  TestAddons/parallel/Registry
addons_test.go:211: registry stabilized in 24.400968ms
=== CONT  TestAddons/parallel/Registry
addons_test.go:213: (dbg) TestAddons/parallel/Registry: waiting 6m0s for pods matching "actual-registry=true" in namespace "kube-system" ...
=== CONT  TestAddons/parallel/Registry
helpers_test.go:335: "registry-x65s9" [d8e5005c-9d91-4bb8-9192-f1103d4c6fba] Running
=== CONT  TestAddons/parallel/Registry
addons_test.go:213: (dbg) TestAddons/parallel/Registry: actual-registry=true healthy within 5.008994314s
=== CONT  TestAddons/parallel/Registry
addons_test.go:216: (dbg) TestAddons/parallel/Registry: waiting 10m0s for pods matching "registry-proxy=true" in namespace "kube-system" ...
helpers_test.go:335: "registry-proxy-vsjkn" [d8202aa1-45d7-4bfe-aa19-54fc9315297d] Running
=== CONT  TestAddons/parallel/Registry
addons_test.go:216: (dbg) TestAddons/parallel/Registry: registry-proxy=true healthy within 5.010342896s
addons_test.go:221: (dbg) Run:  kubectl --context addons-20210310185414-7328 delete po -l run=registry-test --now
addons_test.go:226: (dbg) Run:  kubectl --context addons-20210310185414-7328 run --rm registry-test --restart=Never --image=busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local"
=== CONT  TestAddons/parallel/Registry
addons_test.go:226: (dbg) Non-zero exit: kubectl --context addons-20210310185414-7328 run --rm registry-test --restart=Never --image=busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local": exit status 1 (1m0.141024647s)
-- stdout --
	pod "registry-test" deleted
-- /stdout --
** stderr ** 
	error: timed out waiting for the condition
** /stderr **
addons_test.go:228: failed to hit registry.kube-system.svc.cluster.local. args "kubectl --context addons-20210310185414-7328 run --rm registry-test --restart=Never --image=busybox -it -- sh -c \"wget --spider -S http://registry.kube-system.svc.cluster.local\"" failed: exit status 1
addons_test.go:232: expected curl response be "HTTP/1.1 200", but got *pod "registry-test" deleted
*
addons_test.go:240: (dbg) Run:  out/minikube-linux-amd64 -p addons-20210310185414-7328 ip
2021/03/10 18:58:41 [DEBUG] GET http://192.168.49.161:5000
addons_test.go:269: (dbg) Run:  out/minikube-linux-amd64 -p addons-20210310185414-7328 addons disable registry --alsologtostderr -v=1
@medyagh medyagh added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 10, 2021
@medyagh medyagh changed the title Containerd: TestAddons/parallel/Registry fix registry addon for containerd runtime. Mar 10, 2021
@medyagh medyagh added this to the v.1.19.0 milestone Mar 10, 2021
@afbjorklund
Copy link
Collaborator

It was also broken for CRI-O, and had been broken for Docker too - if it had used CRI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/containerd co/runtime/crio CRIO related issues kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants