Enable portmap for the default cni bridge

[afbjorklund]

Otherwise the registry addon will not work, since it uses
hostPort 5000 (which in turn requires port mapping enabled)

Closes #10778

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10782): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10782/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10782/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10782): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10782/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10782/minikube: exec format error

[medyagh]

registry test still failing @afbjorklund
https://storage.googleapis.com/minikube-builds/logs/10782/71145bc/Docker_Linux_containerd.html#fail_TestAddons%2fparallel%2fRegistry

[medyagh]

@afbjorklund dont we need to add portmap for kindnet cni ?

[afbjorklund]

@afbjorklund dont we need to add portmap for kindnet cni ?

As far as I can tell, it already had it enabled since before:

/etc/cni/net.d/10-kindnet.conflist

{
	"cniVersion": "0.3.1",
	"name": "kindnet",
	"plugins": [
	{
		"type": "ptp",
		"ipMasq": false,
		"ipam": {
			"type": "host-local",
			"dataDir": "/run/cni-ipam-state",
			"routes": [
				{
					"dst": "0.0.0.0/0"
				}
			],
			"ranges": [
			[
				{
					"subnet": "10.244.0.0/24"
				}
			]
		]
		}
		,
		"mtu": 1500
		
	},
	{
		"type": "portmap",
		"capabilities": {
			"portMappings": true
		}
	}
	]
}

https://github.com/kubernetes-sigs/kind/blob/9785fe7b74fdc6980e4402c38c2eebef30ac62e3/images/kindnetd/cmd/kindnetd/cni.go#L102

[afbjorklund]

But for some reason I also had a CRI-O CNI, without it.

docker@docker:~$ more /etc/cni/net.d/
10-kindnet.conflist        100-crio-bridge.conf       200-loopback.conf          87-podman-bridge.conflist

As far as i can tell, kube-proxy was started before kindnetd.

/etc/cni/net.d/100-crio-bridge.conf

{
    "cniVersion": "0.3.1",
    "name": "crio",
    "type": "bridge",
    "bridge": "cni0",
    "isGateway": true,
    "ipMasq": true,
    "hairpinMode": true,
    "ipam": {
        "type": "host-local",
        "routes": [
            { "dst": "0.0.0.0/0" },
            { "dst": "1100:200::1/24" }
        ],
        "ranges": [
            [{ "subnet": "10.85.0.0/16" }],
            [{ "subnet": "1100:200::/24" }]
        ]
    }
}

EDIT: It is included in the cri-o package:

/etc/cni/net.d/100-crio-bridge.conf
/etc/cni/net.d/200-loopback.conf
/etc/crictl.yaml
/etc/crio/crio.conf
/etc/crio/crio.conf.d/01-crio-runc.conf
/etc/default/crio

Removing cri-o makes containerd work again.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment