-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different echoserver images used in different places #15650
Comments
cc @spowelljr |
After all, we've to come up with one image which is common to both. Is this the image The image mentioned here is found to be way less enormous than the one mentioned on Kubernetes docs. However the image mentioned on minikube is found to have more vulnerabilities than the one mentioned in Kubernetes documentation. Before updating the docs image (if we want to), I'd like to know the perspective of what other maintainers have to say about this. The previous version of the image did not support arm64. This one supports amd64, arm, arm64, ppc64le, s390x on Linux, and amd64 on multiple Windows versions. |
The size isn't all that important, but "e2e-test-images" sounds like it is meant for a different purpose (like "kicbase"). The command is somewhat hard to remember, as well. Referring to the So would probably be better to have a dedicated place for images for "getting started", as I'm sure there are more ? And they should probably use the * the main exception being the kubernetes dashboard |
If the minikube documentation is going to stay at the current location, we could make a PR for the documentation site. I see it as possible that "Hello, Minikube" will disappear with the Katacoda removal, and just link to the minikube site ?
The "Create Cluster" also needs modifications, but I opened up a separate issue for that topic: #15651 |
That's a good approach you've suggested. However, What if we modify the documentation of Hello Minikube and replace the Katacoda with Killercoda? |
@kubernetes/minikube-maintainers Kindly take a look onto it! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks Nitish for the ping! He's right, we changed the image because we got many complaint about the previous command not working on arm64. kubernetes/website#37383 We just decided to pick up this image because this is a toolbox image actually maintained by the infra sig! I agree that the command line is slightly more ugly but at least this one came at no supplementary maintaining cost and was working on all platforms. |
Well, it did spend too much time in the backlog. And it was a bit surprising that the amd64 image was left for 5 years. There could be some better communication, though. We have a similar image for registry, abandoned 5 years ago... |
I agree that the name For some examples such as ingress if we use the Current ingress example:
With regard to the security comment, when I scan the
https://nvd.nist.gov/vuln/detail/CVE-2022-37434 And a warning about the Alpine version: We don't want to be managing the images, we just wanted to update the docs so arm64 users weren't failing to run the examples and getting turned off. |
Please consider reporting this sort of thing back to the original source repo. This may already be fixed, as 2.43 is the current tag. |
maybe it would be actually more reasonable to use the |
I think you can open an issue with SIG Docs, if you want to change the legacy tutorial before it is deleted https://kubernetes.io/blog/2023/02/14/kubernetes-katacoda-tutorials-stop-from-2023-03-31/ |
kubernetes does not publish mutable tags to the production registry by policy. |
The rest of the tutorial is like 5+ years old, so it is comparatively new anyway (but still a good idea to report and bump it) Kubernetes 1.20, Ubuntu 18.04, and so on |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The old
k8s.gcr.io/echoserver:1.4
was replaced with different images:https://kubernetes.io/docs/tutorials/hello-minikube/
kubectl create deployment hello-node --image=registry.k8s.io/e2e-test-images/agnhost:2.39 -- /agnhost netexec --http-port=8080
kubernetes/website@25d48ec
kubernetes/website@a180cd6
Update echoserver image in "Hello Minikube" tutorial for multiarch website#37383
https://minikube.sigs.k8s.io/docs/start/
kubectl create deployment hello-minikube --image=kicbase/echo-server:1.0
428a55f
02061ca
site: Update echo-server image #15397
It would probably be better to have this image hosted elsewhere ?
i.e. not "registry.k8s.io/e2e-test-images", not "docker.io/kicbase"
The kubernetes.io image is slightly more enormous, than the minikube:
The minikube image is based on https://github.com/jmalloc/echo-server
The text was updated successfully, but these errors were encountered: