Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake Bot PR commenter should Update the comment instead of making a new comment #15853

Closed
medyagh opened this issue Feb 14, 2023 · 2 comments
Closed
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 14, 2023

minikube has a bot that comments how flaky a test failure on the PR is, but each different test run generates a new comment,
but it should Update the existing comment.
Example:
#15840 (comment)

this is the line that comments on the PRs

https://github.com/medyagh/minikube/blob/99756bef0b9a90b9097668cb4e9c255f387cbadd/hack/jenkins/test-flake-chart/report_flakes.sh#L130

one way of doing it might be changing this
line
gh pr comment "https://github.com/kubernetes/minikube/pull/$PR_NUMBER" --body "$(cat $TMP_COMMENT)"
to (add --edit-last)
gh pr comment "https://github.com/kubernetes/minikube/pull/$PR_NUMBER" --edit-last --body "$(cat $TMP_COMMENT)"

the only problem is the minikube-pr-bot also updates the Performance data too which means if the last data was Performance data, it will over-write it.... (example of the performance PR comment)

@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 15, 2023
@spowelljr spowelljr self-assigned this Mar 15, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2023
@spowelljr
Copy link
Member

Instead we hide the previous comments now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants