Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download binaries from dl.k8s.io instead of GCS #15840

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Download binaries from dl.k8s.io instead of GCS #15840

merged 1 commit into from
Feb 14, 2023

Conversation

afbjorklund
Copy link
Collaborator

Closes #14828

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2023
@afbjorklund afbjorklund changed the title Download binaries from dl.k8s.io instead of GCR Download binaries from dl.k8s.io instead of GCS Feb 13, 2023
@afbjorklund afbjorklund mentioned this pull request Feb 13, 2023
Closed
@afbjorklund
Download binaries from dl.k8s.io instead of GCS
99bff1e 
Need to add the -L to curl, to follow HTTP 302

Don't change the path for the current GCS mirror
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 13, 2023
@medyagh
Copy link
Member

medyagh commented Feb 13, 2023

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15840) |
+----------------+----------+---------------------+
| minikube start | 54.2s    | 54.6s               |
| enable ingress | 26.7s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 58.1s 55.0s 51.3s 55.1s 51.4s
Times for minikube (PR 15840) start: 53.3s 56.6s 55.6s 54.0s 53.5s

Times for minikube ingress: 28.8s 25.2s 25.7s 25.3s 28.2s
Times for minikube (PR 15840) ingress: 25.3s 27.8s 28.2s 25.2s 30.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15840) |
+----------------+----------+---------------------+
| minikube start | 26.5s    | 27.0s               |
| enable ingress | 20.7s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 26.9s 26.5s 26.2s 27.0s 26.1s
Times for minikube (PR 15840) start: 28.1s 27.1s 26.3s 27.2s 26.3s

Times for minikube (PR 15840) ingress: 21.1s 22.1s 24.1s 25.1s 22.1s
Times for minikube ingress: 21.6s 20.1s 21.6s 21.1s 19.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15840) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.8s               |
| enable ingress | 48.4s    | 35.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.6s 49.1s 31.6s 80.1s 47.6s
Times for minikube (PR 15840) ingress: 50.6s 32.6s 32.6s 31.6s 31.6s

Times for minikube start: 22.2s 21.4s 21.7s 21.2s 21.8s
Times for minikube (PR 15840) start: 21.8s 21.3s 20.8s 22.4s 22.9s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestFunctional/parallel/DashboardCmd (gopogh) 1.26 (chart)
Hyper-V_Windows TestAddons/parallel/CloudSpanner (gopogh) 10.29 (chart)
Hyperkit_macOS TestFunctional/parallel/ConfigCmd (gopogh) 16.90 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.68 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
KVM_Linux TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 80.88 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 89.86 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 92.75 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.68 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh mentioned this pull request Feb 14, 2023
Closed
@medyagh medyagh merged commit 6a2fc9a into kubernetes:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using gs://kubernetes-release bucket, use dl.k8s.io for downloads
5 participants
@afbjorklund @spowelljr @medyagh @minikube-pr-bot @k8s-ci-robot